Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moar tests #228

Merged
merged 6 commits into from
Jul 20, 2023
Merged

Moar tests #228

merged 6 commits into from
Jul 20, 2023

Conversation

bizob2828
Copy link
Member

Proposed Release Notes

  • Refactored code to make it easier to test
  • Add full suite of unit tests

Links

Closes #223

Details

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #228 (56dce51) into main (4386ff0) will increase coverage by 9.62%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   87.57%   97.19%   +9.62%     
==========================================
  Files           4        5       +1     
  Lines         700      713      +13     
==========================================
+ Hits          613      693      +80     
+ Misses         87       20      -67     
Flag Coverage Δ
integration-tests-14.x-linux 84.57% <73.50%> (+1.42%) ⬆️
integration-tests-14.x-windows-2019 78.96% <56.00%> (+2.24%) ⬆️
integration-tests-16.x-linux 84.57% <73.50%> (+1.42%) ⬆️
integration-tests-16.x-windows-2019 78.96% <56.00%> (+2.24%) ⬆️
integration-tests-18.x-linux 84.29% <73.50%> (+1.43%) ⬆️
integration-tests-18.x-windows-2019 78.68% <56.00%> (+2.25%) ⬆️
integration-tests-18.x-windows-latest 78.68% <56.00%> (+2.25%) ⬆️
unit-tests-14.x-linux 87.93% <93.50%> (+39.93%) ⬆️
unit-tests-14.x-windows-2019 87.79% <93.50%> (+39.79%) ⬆️
unit-tests-16.x-linux 87.93% <93.50%> (+39.93%) ⬆️
unit-tests-16.x-windows-2019 87.79% <93.50%> (+39.79%) ⬆️
unit-tests-18.x-linux 87.65% <93.50%> (+39.94%) ⬆️
unit-tests-18.x-windows-2019 87.51% <93.50%> (+39.80%) ⬆️
unit-tests-18.x-windows-latest 87.51% <93.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/pre-build.js 96.96% <93.87%> (+18.78%) ⬆️
lib/gyp-utils.js 98.01% <98.01%> (ø)
lib/common.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmartin4563 jmartin4563 self-assigned this Jul 18, 2023
Copy link
Contributor

@jmartin4563 jmartin4563 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're gonna have to merge main in to get the required checks, but this is good to go!

@bizob2828 bizob2828 merged commit 46b4261 into newrelic:main Jul 20, 2023
10 checks passed
@github-actions github-actions bot mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Increase unit test coverage in native-metrics
2 participants