Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Removed support for Node.js 16 #273

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

bizob2828
Copy link
Member

Description

Aside from dropping node-gyp since the version on 18+ is ok for our CI. I was able to drop semver because we're no longer on 16

Related Issues

Closes #249

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (de17116) to head (e9c7265).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #273      +/-   ##
==========================================
- Coverage   97.81%   97.59%   -0.23%     
==========================================
  Files           1        1              
  Lines         183      166      -17     
==========================================
- Hits          179      162      -17     
  Misses          4        4              
Flag Coverage Δ
integration-tests-16-ubuntu-latest-x64 ?
integration-tests-16-windows-latest-x64 ?
integration-tests-16-windows-latest-x86 ?
integration-tests-18-ubuntu-latest-x64 88.55% <100.00%> (+4.40%) ⬆️
integration-tests-18-windows-latest-x64 88.55% <100.00%> (+4.40%) ⬆️
integration-tests-18-windows-latest-x86 88.55% <100.00%> (+4.40%) ⬆️
integration-tests-20-ubuntu-latest-x64 88.55% <100.00%> (+4.40%) ⬆️
integration-tests-20-windows-latest-x64 88.55% <100.00%> (+4.40%) ⬆️
integration-tests-20-windows-latest-x86 88.55% <100.00%> (+4.40%) ⬆️
integration-tests-22-ubuntu-latest-x64 88.55% <100.00%> (+4.40%) ⬆️
integration-tests-22-windows-latest-x64 88.55% <100.00%> (+4.40%) ⬆️
integration-tests-22-windows-latest-x86 88.55% <100.00%> (+4.40%) ⬆️
unit-tests-16-ubuntu-latest-x64 ?
unit-tests-16-windows-latest-x64 ?
unit-tests-16-windows-latest-x86 ?
unit-tests-18-ubuntu-latest-x64 97.59% <100.00%> (+5.24%) ⬆️
unit-tests-18-windows-latest-x64 97.59% <100.00%> (+5.24%) ⬆️
unit-tests-18-windows-latest-x86 97.59% <100.00%> (+5.24%) ⬆️
unit-tests-20-ubuntu-latest-x64 97.59% <100.00%> (+5.24%) ⬆️
unit-tests-20-windows-latest-x64 97.59% <100.00%> (+5.24%) ⬆️
unit-tests-20-windows-latest-x86 97.59% <100.00%> (+5.24%) ⬆️
unit-tests-22-ubuntu-latest-x64 97.59% <100.00%> (+5.24%) ⬆️
unit-tests-22-windows-latest-x64 97.59% <100.00%> (+5.24%) ⬆️
unit-tests-22-windows-latest-x86 97.59% <100.00%> (+5.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 merged commit 3b10b04 into newrelic:next Jul 24, 2024
17 of 18 checks passed
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants