Skip to content

Commit

Permalink
chore: pin testdobule to 3.17.2 as 3.18.0 no longer works on node 14 (#…
Browse files Browse the repository at this point in the history
…1628)

<!--
Thank you for submitting a Pull Request.

This code is leveraged to monitor critical services. Please consider the
following:
* Tests are required.
* Performance matters.
* Features that are specific to just your app are unlikely to make it
in.

Please fill out the relevant sections as follows:
* Proposed Release Notes: Bulleted list of recommended release notes for
the change(s).
* Links: Any relevant links for the change.
* Details: In-depth description of changes, other technical notes, etc.
-->

## Proposed Release Notes

## Links

## Details
We have to pin `testdouble` until we drop support for node 14.
[3.18.0](https://github.com/testdouble/testdouble.js/blob/main/CHANGELOG.md#3180)
release added support for Node 20 which even though it doesn't call it
out dropped support for 14 and it's breaking our esm unit tests.
  • Loading branch information
bizob2828 committed May 10, 2023
1 parent fea1068 commit d68bd9f
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 30 deletions.
2 changes: 1 addition & 1 deletion THIRD_PARTY_NOTICES.md
Original file line number Diff line number Diff line change
Expand Up @@ -9417,7 +9417,7 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

### testdouble

This product includes source derived from [testdouble](https://github.com/testdouble/testdouble.js) ([v3.16.6](https://github.com/testdouble/testdouble.js/tree/v3.16.6)), distributed under the [MIT License](https://github.com/testdouble/testdouble.js/blob/v3.16.6/LICENSE.txt):
This product includes source derived from [testdouble](https://github.com/testdouble/testdouble.js) ([v3.17.2](https://github.com/testdouble/testdouble.js/tree/v3.17.2)), distributed under the [MIT License](https://github.com/testdouble/testdouble.js/blob/v3.17.2/LICENSE.txt):

```
The MIT License (MIT)
Expand Down
43 changes: 21 additions & 22 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@
"sinon": "^4.5.0",
"tap": "^16.3.4",
"temp": "^0.8.1",
"testdouble": "^3.16.6",
"testdouble": "3.17.2",
"when": "*"
},
"repository": {
Expand Down
12 changes: 6 additions & 6 deletions third_party_manifest.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"lastUpdated": "Thu May 04 2023 11:13:33 GMT-0400 (Eastern Daylight Time)",
"lastUpdated": "Tue May 09 2023 11:02:46 GMT-0400 (Eastern Daylight Time)",
"projectName": "New Relic Node Agent",
"projectUrl": "https://github.com/newrelic/node-newrelic",
"includeOptDeps": true,
Expand Down Expand Up @@ -722,15 +722,15 @@
"publisher": "Bruce Williams",
"email": "[email protected]"
},
"testdouble@3.16.6": {
"testdouble@3.17.2": {
"name": "testdouble",
"version": "3.16.6",
"range": "^3.16.6",
"version": "3.17.2",
"range": "3.17.2",
"licenses": "MIT",
"repoUrl": "https://github.com/testdouble/testdouble.js",
"versionedRepoUrl": "https://github.com/testdouble/testdouble.js/tree/v3.16.6",
"versionedRepoUrl": "https://github.com/testdouble/testdouble.js/tree/v3.17.2",
"licenseFile": "node_modules/testdouble/LICENSE.txt",
"licenseUrl": "https://github.com/testdouble/testdouble.js/blob/v3.16.6/LICENSE.txt",
"licenseUrl": "https://github.com/testdouble/testdouble.js/blob/v3.17.2/LICENSE.txt",
"licenseTextSource": "file",
"publisher": "Justin Searls",
"email": "[email protected]",
Expand Down

0 comments on commit d68bd9f

Please sign in to comment.