ci: Add Node.js 20.x to CI and remove 14.x #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
force-pushed
the
node-20
branch
2 times, most recently
from
a798d24
to
025a985
Compare
Codecov Report
@@ Coverage Diff @@
## main #1603 +/- ##
==========================================
- Coverage 96.87% 96.85% -0.02%
==========================================
Files 200 200
Lines 39191 39205 +14
Branches 25 23 -2
==========================================
+ Hits 37966 37972 +6
- Misses 1225 1233 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
There are 2 smoke test files failing on 20 because of the self-signed cert. I'm triaging that separately. |
…s as they are not necessary
jmartin4563
previously approved these changes
Jul 24, 2023
jmartin4563
approved these changes
Jul 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Links
Closes #1726
Details
This was mostly a clean upgrade. I have skipped the ESM tests as we know the ESM loader isn't working. I will unleash those tests when I PR that fix. The highlights here are that server.close changed behavior so I just made tests bind to dynamic ports to workaround this issue. There's also 2 features that no longer ship with node around dtrace and etw.