Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated mysql instrumentation to properly wrap the connection pool.getConnection and poolCluster.of #1647

Merged
merged 12 commits into from
May 23, 2023
Merged

fix: Updated mysql instrumentation to properly wrap the connection pool.getConnection and poolCluster.of #1647

merged 12 commits into from
May 23, 2023

Commits on May 22, 2023

  1. Set state of callback to not-wrapped at the beginning of initialization 

    Signed-off-by: mrickard <[email protected]>
    @mrickard @bizob2828
    mrickard authored and bizob2828 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    033676e View commit details
    Browse the repository at this point in the history

  2. updates tests to show failing tests, does expose new issue around clu… 

    …ster.of though
    @bizob2828
    bizob2828 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    2647571 View commit details
    Browse the repository at this point in the history

  3. Changed mysql basic-pool test variable names to match mysql2. Fixed t… 

    …ypos

Signed-off-by: mrickard <[email protected]>
    @mrickard @bizob2828
    mrickard authored and bizob2828 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    f316369 View commit details
    Browse the repository at this point in the history

  4. Fixed typos in mysql/mysql2 basic-pool tests 

    Signed-off-by: mrickard <[email protected]>
    @mrickard @bizob2828
    mrickard authored and bizob2828 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    b1f627a View commit details
    Browse the repository at this point in the history

  5. Fixed typos in mysql basic-pool assertions 

    Signed-off-by: mrickard <[email protected]>
    @mrickard @bizob2828
    mrickard authored and bizob2828 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    f0d0342 View commit details
    Browse the repository at this point in the history

  6. Replaced deprecated .notEqual with recommended .not in mysql/mysql2 b… 

    …asic-pool.tap.js

Signed-off-by: mrickard <[email protected]>
    @mrickard @bizob2828
    mrickard authored and bizob2828 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    90a5a44 View commit details
    Browse the repository at this point in the history

  7. Moved getDomainSocketPath in mysql2 basic-pool.tap.js, to align it mo… 

    …re closely with mysql/basic-pool.tap.js

Signed-off-by: mrickard <[email protected]>
    @mrickard @bizob2828
    mrickard authored and bizob2828 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    98cfdf6 View commit details
    Browse the repository at this point in the history

  8. Removed calls to setup in mysql2/basic-pool.tap.js. The setup functio… 

    …n uses a non-pooled connection

Signed-off-by: mrickard <[email protected]>
    @mrickard @bizob2828
    mrickard authored and bizob2828 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    572430b View commit details
    Browse the repository at this point in the history

  9. Fixed assertion typos 

    Signed-off-by: mrickard <[email protected]>
    @mrickard @bizob2828
    mrickard authored and bizob2828 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    565ac6d View commit details
    Browse the repository at this point in the history

  10. feat: added proper instrumentation for PoolNamespace.prototype.query

    @bizob2828
    bizob2828 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    f38cd80 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Standardized datastore_tracer.instance_reporting tests in both basic-… 

    …pool.tap.js files

Signed-off-by: mrickard <[email protected]>
    @mrickard
    mrickard committed May 23, 2023
    Configuration menu
    Copy the full SHA
    23332bb View commit details
    Browse the repository at this point in the history

  2. Removed unneeded timeout from mysql basic-pool callback test 

    Signed-off-by: mrickard <[email protected]>
    @mrickard
    mrickard committed May 23, 2023
    Configuration menu
    Copy the full SHA
    c75f383 View commit details
    Browse the repository at this point in the history