Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): convert error-trace-aggregator.test.js to tap-style #1690

Merged

Conversation

mrickard
Copy link
Member

Description

Converted error-trace-aggregator.test.js to use tap instead of mocha.

Related Issues

Closes #1689
Closes NR-129077

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1690 (00f82d7) into main (2a89153) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1690   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files         200      200           
  Lines       39180    39180           
  Branches       24       24           
=======================================
  Hits        37955    37955           
  Misses       1225     1225           
Flag Coverage Δ
esm-unit-tests-14.x 47.80% <ø> (ø)
esm-unit-tests-16.x 92.11% <ø> (ø)
esm-unit-tests-18.x 92.11% <ø> (ø)
integration-tests-14.x 78.98% <ø> (+0.01%) ⬆️
integration-tests-16.x 79.06% <ø> (ø)
integration-tests-18.x 79.08% <ø> (ø)
unit-tests-14.x 91.41% <ø> (ø)
unit-tests-16.x 91.46% <ø> (ø)
unit-tests-18.x 91.44% <ø> (ø)
versioned-tests-14.x 75.71% <ø> (-0.06%) ⬇️
versioned-tests-16.x 77.03% <ø> (-0.05%) ⬇️
versioned-tests-18.x 77.03% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmartin4563 jmartin4563 self-assigned this Jun 23, 2023
@jmartin4563 jmartin4563 added the dev:tests Indicates only changes to tests label Jun 23, 2023
Copy link
Contributor

@jmartin4563 jmartin4563 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very straightforward!

@mrickard mrickard changed the title chore: convert error-trace-aggregator.test.js to tap-style chore(test): convert error-trace-aggregator.test.js to tap-style Jun 26, 2023
@mrickard mrickard merged commit 44b17ab into newrelic:main Jun 26, 2023
20 checks passed
@github-actions github-actions bot mentioned this pull request Jun 26, 2023
@mrickard mrickard deleted the NR-129077/error-trace-aggregator-test branch April 29, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Convert 'test/unit/errors/error-trace-aggregator.test.js' to tap-style
2 participants