Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Renamed shim.handleCATHeaders to shim.handleMqTracingHeaders #1735

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

mrickard
Copy link
Member

Description

Renamed handleCATHeaders to handleMqTracingHeaders. This function handles both distributed tracing and cross-application-tracing headers for message queues. CAT is going to be removed, leaving just the DT functionality.

How to Test

test/unit/ship/transaction-shim.test.js covers this file.

Related Issues

Closes #903
Closes NR-133499

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1735 (34633ca) into main (0b96de3) will increase coverage by 0.01%.
Report is 16 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1735      +/-   ##
==========================================
+ Coverage   96.87%   96.88%   +0.01%     
==========================================
  Files         200      200              
  Lines       39181    39210      +29     
  Branches       24       22       -2     
==========================================
+ Hits        37956    37989      +33     
+ Misses       1225     1221       -4     
Flag Coverage Δ
esm-unit-tests-14.x ?
esm-unit-tests-16.x 92.85% <ø> (+0.74%) ⬆️
esm-unit-tests-18.x 92.85% <ø> (+0.74%) ⬆️
integration-tests-14.x ?
integration-tests-16.x 79.14% <40.00%> (+0.01%) ⬆️
integration-tests-18.x 79.14% <40.00%> (+0.01%) ⬆️
integration-tests-20.x 79.15% <40.00%> (?)
unit-tests-14.x ?
unit-tests-16.x 91.46% <100.00%> (-0.02%) ⬇️
unit-tests-18.x 91.44% <100.00%> (-0.02%) ⬇️
unit-tests-20.x 91.44% <100.00%> (?)
versioned-tests-16.x 77.19% <100.00%> (+0.11%) ⬆️
versioned-tests-18.x 77.18% <100.00%> (?)
versioned-tests-20.x 76.03% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/shim/message-shim.js 97.08% <100.00%> (ø)
lib/shim/transaction-shim.js 94.49% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment/question

lib/shim/transaction-shim.js Outdated Show resolved Hide resolved
@bizob2828 bizob2828 added the semver: major Backwards incompatible changes. label Aug 2, 2023
@bizob2828 bizob2828 self-assigned this Aug 2, 2023
@bizob2828 bizob2828 changed the title chore: Renamed handleCATHeaders to handleMqTracingHeaders feat!: Renamed shim.handleCATHeaders to shim.handleMqTracingHeaders Aug 2, 2023
@bizob2828
Copy link
Member

I will merge this to ensure we include the commit body with more context for the changelog

@bizob2828 bizob2828 merged commit 6788f9e into newrelic:main Aug 16, 2023
18 checks passed
This was referenced Aug 21, 2023
@mrickard mrickard deleted the NR-133499/rename-dt-shim-for-queues branch October 3, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: major Backwards incompatible changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Rename or restructure DT handling for message queues / via transaction-shim
2 participants