fix: updated prisma instrumentation to parse prisma datamodel with internal package #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrickard
approved these changes
Aug 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #1765 +/- ##
==========================================
- Coverage 96.83% 96.83% -0.01%
==========================================
Files 198 198
Lines 38789 38766 -23
==========================================
- Hits 37562 37539 -23
Misses 1227 1227
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had issues in the past with parsing the prisma connection string and provider. In #1634 I moved it to parsing the schema with a 3rd party DSL parser. I reached out to the prisma contributors and asked to re-expose getConfig. But they mentioned just trying out the wasm package. I made this dep optional because not everyone uses prisma and it requires your build system to be configured to build node packages.