feat: Updated agent initialization to allow running in worker threads when config.worker_threads.enabled is true #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when config.worker_threads.enabled is true
Codecov Report
@@ Coverage Diff @@
## main #1817 +/- ##
=======================================
Coverage 96.83% 96.83%
=======================================
Files 199 199
Lines 38959 38983 +24
=======================================
+ Hits 37724 37748 +24
Misses 1235 1235
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mrickard
reviewed
Oct 16, 2023
mrickard
previously approved these changes
Oct 16, 2023
mrickard
approved these changes
Oct 17, 2023
This was referenced Oct 23, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To restore behavior for some customers wanting to run in worker threads, they can set
config.worker_threads.enabledto true in config of setNEW_RELIC_WORKER_THREADS_ENABLEDtotrue. I tried to be clear and proivde warnings that running in worker threads is not officially supported. It seems as though some customers may find it valuable but we want to default to disable running in worker threads and allow customers to opt-in.