-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updated mysql tests to use MySQL 8.3 #2280
Conversation
await runCommand(client, `FLUSH PRIVILEGES`) | ||
await runCommand(client, `FLUSH TABLES`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we really need these, but they certainly don't hurt.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2280 +/- ##
==========================================
- Coverage 96.27% 96.27% -0.01%
==========================================
Files 284 284
Lines 45230 45230
==========================================
- Hits 43544 43543 -1
- Misses 1686 1687 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR resolves #2269.
We limit the Docker image to
mysql:8.3
because in 8.4 they removed the configuration we need in order to make our tests work with themysql
npm package. See