Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrated test/unit/spans to use node:test #2556

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

bizob2828
Copy link
Member

Description

Migrated test/unit/spans tests to node:test.

Related Issues

Closes #2550

@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (252f3b2) to head (b16613d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2556   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         289      289           
  Lines       45448    45448           
=======================================
  Hits        44172    44172           
  Misses       1276     1276           
Flag Coverage Δ
integration-tests-cjs-18.x 73.82% <ø> (ø)
integration-tests-cjs-20.x 73.83% <ø> (ø)
integration-tests-cjs-22.x 73.86% <ø> (ø)
integration-tests-esm-18.x 49.18% <ø> (ø)
integration-tests-esm-20.x 49.19% <ø> (ø)
integration-tests-esm-22.x 49.21% <ø> (ø)
unit-tests-18.x 88.76% <ø> (ø)
unit-tests-20.x 88.76% <ø> (ø)
unit-tests-22.x 88.77% <ø> (ø)
versioned-tests-18.x 78.85% <ø> (-0.14%) ⬇️
versioned-tests-20.x 78.89% <ø> (-0.10%) ⬇️
versioned-tests-22.x 78.89% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 merged commit 9319071 into main Sep 10, 2024
55 of 56 checks passed
@bizob2828 bizob2828 deleted the convert-span-tests branch September 10, 2024 19:12
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
sumitsuthar pushed a commit to k2io/fork-node-newrelic that referenced this pull request Sep 20, 2024
sumitsuthar added a commit to k2io/fork-node-newrelic that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Convert test/unit/spans to node:test
2 participants