-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate block of unit tests to node:test #2604
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2604 +/- ##
==========================================
- Coverage 97.23% 97.18% -0.05%
==========================================
Files 291 291
Lines 45941 45941
==========================================
- Hits 44670 44648 -22
- Misses 1271 1293 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c9d61ab
to
adf3ae2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tiny suggestion
test/unit/is-absolute-path.test.js
Outdated
const tap = require('tap') | ||
const test = require('node:test') | ||
const assert = require('node:assert') | ||
|
||
const isAbsolutePath = require('../../lib/util/is-absolute-path') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move this to test/unit/util
?
This PR resolves #2603.