chore: Add rules engine to match OTEL spans #2694
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2694 +/- ##
===========================================
+ Coverage 79.26% 97.31% +18.05%
===========================================
Files 281 296 +15
Lines 44906 46597 +1691
===========================================
+ Hits 35593 45345 +9752
+ Misses 9313 1252 -8061
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bizob2828
force-pushed
the
next
branch
2 times, most recently
from
ef91b23
to
aac7e75
Compare
lib/otel/rules.test.js
Outdated
|
|
||
| // Based upon https://github.com/open-telemetry/opentelemetry-js/blob/8fc76896595aac912bf9e15d4f19c167317844c8/packages/opentelemetry-sdk-trace-base/test/common/Span.test.ts#L851 | ||
|
|
||
| const test = require('node:test') |
There was a problem hiding this comment.
is this test even getting run? it's not in the tests folder
There was a problem hiding this comment.
It is not getting run automatically at this time. I only wanted to be able to verify the work while we hash out the structure and underlying details. My intention is to relocate it as we draw near to it being a real feature.
bizob2828
force-pushed
the
next
branch
2 times, most recently
from
e88845f
to
22bca8d
Compare
|
There's a linting error |
I know. I don't know why, though. How was I able to install and use the package if it isn't published? I'm going to shove a lint exception in there, but I have that fork in a state of change and don't want to switch branches. I'll get it updated when I get to a point where I can switch branches. |
Hmm, let me take a closer look, we shouldn't have to do that |
|
Linting is failing because the test is in lib. I moved to a mirrored folder in |
That's... amazing. |
This PR resolves #2667.