Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated express-esm, generic-pool, grpc, & grpc-esm tests to node:test #2702

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves #2682.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (9e98b18) to head (2cb3662).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2702       +/-   ##
===========================================
+ Coverage   79.26%   97.19%   +17.93%     
===========================================
  Files         284      294       +10     
  Lines       44940    46107     +1167     
===========================================
+ Hits        35621    44815     +9194     
+ Misses       9319     1292     -8027     
Flag Coverage Δ
integration-tests-cjs-18.x 74.27% <0.00%> (?)
integration-tests-cjs-20.x 74.28% <0.00%> (?)
integration-tests-cjs-22.x 74.32% <0.00%> (?)
integration-tests-esm-18.x 49.92% <ø> (ø)
integration-tests-esm-20.x 49.92% <ø> (ø)
integration-tests-esm-22.x 49.95% <ø> (ø)
unit-tests-18.x 88.91% <0.00%> (?)
unit-tests-20.x 88.91% <0.00%> (?)
unit-tests-22.x 88.92% <0.00%> (?)
versioned-tests-18.x 78.97% <100.00%> (-0.20%) ⬇️
versioned-tests-20.x 78.98% <100.00%> (-0.20%) ⬇️
versioned-tests-22.x 78.99% <100.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr marked this pull request as ready for review November 5, 2024 20:24
@bizob2828 bizob2828 merged commit a229bbf into newrelic:main Nov 8, 2024
27 checks passed
@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Nov 8, 2024
@jsumners-nr jsumners-nr deleted the issue-2682 branch November 8, 2024 16:59
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
jsumners-nr added a commit to jsumners-nr/node-newrelic that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Migrate express-esm, generic pool, grpc, grpc-esm versioned tests to node:test
2 participants