Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added segment tree to transaction trace #2710

Closed
wants to merge 4 commits into from

Conversation

bizob2828
Copy link
Member

Description

Adds a new data structure to the trace that stores all segments in a tree.

Related Issues

Closes #2696

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 99.74598% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.32%. Comparing base (aac7e75) to head (552f81b).
Report is 12 commits behind head on next.

Files with missing lines Patch % Lines
lib/shim/shim.js 98.95% 2 Missing ⚠️
lib/instrumentation/when/index.js 96.77% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2710   +/-   ##
=======================================
  Coverage   97.31%   97.32%           
=======================================
  Files         294      295    +1     
  Lines       46324    46412   +88     
=======================================
+ Hits        45082    45170   +88     
  Misses       1242     1242           
Flag Coverage Δ
integration-tests-cjs-18.x 74.31% <76.86%> (+0.04%) ⬆️
integration-tests-cjs-20.x 74.32% <76.86%> (+0.05%) ⬆️
integration-tests-cjs-22.x 74.35% <76.86%> (+0.04%) ⬆️
integration-tests-esm-18.x 49.86% <30.19%> (-0.02%) ⬇️
integration-tests-esm-20.x 49.86% <30.19%> (-0.02%) ⬇️
integration-tests-esm-22.x 49.89% <30.19%> (-0.02%) ⬇️
unit-tests-18.x 89.00% <84.42%> (+0.08%) ⬆️
unit-tests-20.x 89.00% <84.42%> (+0.08%) ⬆️
unit-tests-22.x 89.01% <84.42%> (+0.08%) ⬆️
versioned-tests-18.x 79.11% <89.05%> (-0.04%) ⬇️
versioned-tests-20.x 79.11% <89.05%> (?)
versioned-tests-22.x 79.15% <89.05%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jsumners-nr
jsumners-nr previously approved these changes Nov 7, 2024
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No blockers from me.

test/unit/transaction/trace/segment-tree.test.js Outdated Show resolved Hide resolved
@bizob2828
Copy link
Member Author

this is becoming a mess rebasing. I'm just going to cherry pick the commits to a new branch from next

@bizob2828 bizob2828 closed this Nov 8, 2024
@bizob2828 bizob2828 deleted the cache-segment-tree branch November 8, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

2 participants