Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrated ioredis, prisma and undici versioned tests to node:test #2746

Merged

Conversation

bizob2828
Copy link
Member

Related Issues

Closes #2730

@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.20%. Comparing base (004fd12) to head (63f189f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2746      +/-   ##
==========================================
- Coverage   97.25%   97.20%   -0.05%     
==========================================
  Files         294      294              
  Lines       46233    46233              
==========================================
- Hits        44964    44943      -21     
- Misses       1269     1290      +21     
Flag Coverage Δ
integration-tests-cjs-18.x 74.28% <ø> (?)
integration-tests-cjs-20.x 74.30% <ø> (+<0.01%) ⬆️
integration-tests-cjs-22.x 74.33% <ø> (ø)
integration-tests-esm-18.x 49.92% <ø> (ø)
integration-tests-esm-20.x 49.93% <ø> (ø)
integration-tests-esm-22.x 49.95% <ø> (ø)
unit-tests-18.x 88.96% <ø> (ø)
unit-tests-20.x 88.96% <ø> (?)
unit-tests-22.x 88.97% <ø> (ø)
versioned-tests-18.x 78.97% <ø> (-0.20%) ⬇️
versioned-tests-20.x 78.98% <ø> (-0.20%) ⬇️
versioned-tests-22.x 78.99% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bizob2828 bizob2828 merged commit 449ae03 into newrelic:main Nov 15, 2024
28 of 29 checks passed
@bizob2828 bizob2828 deleted the migrate-ioredis-prisma-undici-tests branch November 15, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Migrate memcached ioredis, prisma and undici versioned tests to node:test
2 participants