Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow separated definition of resources for ksm and forwarder #1115

Closed

Conversation

jddcarreira
Copy link

@jddcarreira jddcarreira commented Oct 17, 2024

Description

Currently the ksm template uses the same resources values for KSM and NR Forwarder inside the pod.

In most of the cases the KSM is the component responsible for resources exhaustion, and increasing both will result in significant underutilisation of the resources for NR Forwarder.

This MR adds separated options in the values.yml to specify dedicated resources for each pod.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@jddcarreira jddcarreira requested a review from a team as a code owner October 17, 2024 11:24
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.40%. Comparing base (1aedf25) to head (da865d3).
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1115      +/-   ##
==========================================
- Coverage   67.80%   66.40%   -1.40%     
==========================================
  Files          55       55              
  Lines        3379     4272     +893     
==========================================
+ Hits         2291     2837     +546     
- Misses        909     1256     +347     
  Partials      179      179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbudziwojskiNR dbudziwojskiNR changed the title Allow separated definition of resources for ksm and forwarder feat: Allow separated definition of resources for ksm and forwarder Oct 18, 2024
@csongnr
Copy link
Contributor

csongnr commented Oct 22, 2024

hey @jddcarreira can you sign the CLA? thank you

@csongnr
Copy link
Contributor

csongnr commented Nov 7, 2024

PR recreated here: #1130

@csongnr csongnr closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants