-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow separated definition of resources for ksm and forwarder #1115
Closed
jddcarreira
wants to merge
7
commits into
newrelic:main
from
jddcarreira:allowResourcesForKSMForwarder
Closed
feat: Allow separated definition of resources for ksm and forwarder #1115
jddcarreira
wants to merge
7
commits into
newrelic:main
from
jddcarreira:allowResourcesForKSMForwarder
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1115 +/- ##
==========================================
- Coverage 67.80% 66.40% -1.40%
==========================================
Files 55 55
Lines 3379 4272 +893
==========================================
+ Hits 2291 2837 +546
- Misses 909 1256 +347
Partials 179 179 ☔ View full report in Codecov by Sentry. |
dbudziwojskiNR
changed the title
Allow separated definition of resources for ksm and forwarder
feat: Allow separated definition of resources for ksm and forwarder
Oct 18, 2024
hey @jddcarreira can you sign the CLA? thank you |
csongnr
reviewed
Oct 22, 2024
9 tasks
csongnr
added a commit
that referenced
this pull request
Nov 7, 2024
PR recreated here: #1130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the ksm template uses the same resources values for KSM and NR Forwarder inside the pod.
In most of the cases the KSM is the component responsible for resources exhaustion, and increasing both will result in significant underutilisation of the resources for NR Forwarder.
This MR adds separated options in the values.yml to specify dedicated resources for each pod.
Type of change
Checklist: