Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SCRAM-SHA-256 authentication #67

Closed
ngalantowicz opened this issue May 18, 2021 · 12 comments
Closed

Add support for SCRAM-SHA-256 authentication #67

ngalantowicz opened this issue May 18, 2021 · 12 comments

Comments

@ngalantowicz
Copy link

Is your feature request related to a problem? Please describe.

Integration fails due to no mongo 4+ SCRAM-SHA-256 authentication support. I've found that the driver you all use has yet to enable support for SCRAM-SHA-256 authentication as well. There's an existing pr (stale - 2+ years old) in the driver repo you all use. I understand that this will need to be done first in order to enable here, so I'm curious and asking if the mgo feature is completed would you all be willing to support it.

Feature Description

Enable mongo 4+ SCRAM-SHA-256 authentication mechanism

Describe Alternatives

n/a

Additional context

Existing mgo pr seeking support for completion

Priority

Blocker

@ngalantowicz
Copy link
Author

My bad I didn't mean to close got a little trigger happy :)

@gsanchezgavier gsanchezgavier added feature request Categorizes issue or PR as related to a new feature or enhancement. priority/pending labels Jun 1, 2021
@gsanchezgavier
Copy link
Contributor

Hi @ngalantowicz , this really looks interesting i have tagged this issue to be prioritized by our PM.

@roobre
Copy link
Contributor

roobre commented Jun 8, 2021

Hi,

We are currently using the mgo driver which, to our knowledge, is now kind of in a "maintenance mode", and it's hard to get new features added to it, so I wouldn't be too optimistic regarding that PR getting merged.

We have talked a couple times about migrating to the official mongo driver, and this could be something to weight in for that. Are you aware if the official driver supports SCRAM?

@gsanchezgavier gsanchezgavier added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jun 8, 2021
@ngalantowicz
Copy link
Author

@gsanchezgavier and @roobre thanks for taking an interest in this feature.

The official mongo driver does support SCRAM

https://github.com/mongodb/mongo-go-driver/blob/master/mongo/options/clientoptions.go#L45-#L46

@roobre roobre added this to the Official driver migration milestone Jun 11, 2021
@roobre
Copy link
Contributor

roobre commented Jun 11, 2021

@ngalantowicz Thanks for the confirmation! We'll add this to the list of things to track for the migration :)

@roobre roobre added priority/backlog Generalistic priority. and removed priority/pending labels Jun 11, 2021
@mangulonr mangulonr added priority/long-term Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/backlog Generalistic priority. labels Jun 25, 2021
@davidgit davidgit removed this from the Official driver migration milestone Aug 26, 2021
@paologallinaharbur
Copy link
Member

paologallinaharbur commented Oct 11, 2021

Same applies for SCRAM-SHA-1 blocked by #71

@Neustradamus
Copy link

Neustradamus commented Jan 8, 2022

@ all: I wish you a Happy New Year 2022!

Any news about it?

Linked to:

@pyrotechnics-io
Copy link

pyrotechnics-io commented Jul 17, 2022

Incidentally, I'm working on a fork which essentially removes globalsign/mgo in favour of the mongodb official driver here : https://github.com/pyrotechnics-io/nri-mongodb/tree/hbaste-scramsha256. This would at least in theory allow it to be used for SCRAM-SHA-256 as well as MongoDB 5 (has undergone some very basic testing against 4.4 with SCRAM-SHA-256). The approach followed is to mimick the interface of mgo as used in the code with a facade wrapper and then eventually refactor and do away with the wrapper altogether. A lot of the test code had deep hooks into mgo objects unfortunately so had to temporarily disable several of them.

Disclaimer: Its still a pre-alpha wip but any help testing it is much appreciated.

@pyrotechnics-io
Copy link

Just fyi but if testing is validated, the fork above in theory should address #67, #70, #71, #76, #78

@davidgit davidgit removed triage/accepted Indicates an issue or PR is ready to be actively worked on. feature request Categorizes issue or PR as related to a new feature or enhancement. priority/long-term Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Oct 7, 2022
@workato-integration
Copy link

@mangulonr
Copy link
Contributor

Hi

The new MongoDB OHI has been released in public preview, this version will be GA during June.

Some of the new features provided:

For more information check the following resources.

Because it is based on Prometheus the metric names are different from our legacy OHI, check our migration guide if you need more details.
Our legacy MongoDB OHI will be deprecated on FY24H2 (final date pending to be decided).

@workato-integration
Copy link

Work has been completed on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants