-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build/782 parallel cypress webpack 5 #800
Conversation
This reverts commit a68affe.
You can preview these changes on: |
cy.wait(1000); | ||
)}${route}`, () => { | ||
cy.mockConsentAndVisit(route); | ||
cy.wait(1000); // FIX: This accounts for 2mins of the test run time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume it fails without that wait? Perhaps it could wait for something to appear in the DOM instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect it to get increasingly flakey the lower the number gets, It was in there from before, I'll spin it out into a separate task to take a look at as would like to get this merged. The Impact of this will be a bit less than 2mins given it's now parallelized. so possibly not as high priority as say compared to the rspack work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember @baburay23 looked into this when there was a bug and added intercepts for all the api calls. So I'm not sure what the wait
is waiting for. So it might be that this can just be deleted. Did you have issues without it?
I've noticed that package.json contains "@types/webpack": "^4.4.34" |
addressed in #804 |
#782
What
The following image shows some of the tunings that I looked at as part of this work. unfortunately, cypress-parallel becomes flakey at higher worker counts. It's not immediately clear what the issue is here.
^1 because of the limitation / bug in cypress-parallel it may be beneficial to take a look at sorry-cypress again at some point in the future so we can better utilize large instance sizes in CirlceIC and increased benefit. Setting this up will be less simple than cypress-parallel as it requires it's orchestration service to be running. I do have an example of running this locally available in this commit 72cd996
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: