-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step4 - GitHub(인기 저장소) #32
Open
oyj7677
wants to merge
13
commits into
next-step:oyj7677
Choose a base branch
from
oyj7677:Step4
base: oyj7677
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Sep 7, 2024
-
Refactor : MainScreen 컴포넌트 stateful, stateless 오버로딩
1. MainActivity에 있는 상태값들 stateful한 MainScreen 컴포넌트로 이동.
Configuration menu - View commit details
-
Copy full SHA for c939c8d - Browse repository at this point
Copy the full SHA c939c8dView commit details -
1. RepositoryEntity, GithubRepositoryInfo에 stars프로퍼티 추가. 2. 관련 코드 수정
Configuration menu - View commit details
-
Copy full SHA for 19178df - Browse repository at this point
Copy the full SHA 19178dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2eb2e0 - Browse repository at this point
Copy the full SHA c2eb2e0View commit details -
1. 저장소 칼럼 헤더에 Star 개수 노출 2. Star 개수 50개 이상일 시 HOT 문구 노출
Configuration menu - View commit details
-
Copy full SHA for 350adaa - Browse repository at this point
Copy the full SHA 350adaaView commit details -
1. 저장소 Star 개수 노출 2. 저장소 Star 개수 50개 이상 시 HOT 텍스트 노출
Configuration menu - View commit details
-
Copy full SHA for 00f6759 - Browse repository at this point
Copy the full SHA 00f6759View commit details
Commits on Sep 9, 2024
-
1. domain 패키지 생성 2. GithubViewModel 파리미터 변경 (저장소 -> 유즈케이스) 3. GetGithubRepoUseCase 구현
Configuration menu - View commit details
-
Copy full SHA for d37ccdc - Browse repository at this point
Copy the full SHA d37ccdcView commit details -
Rename : data 및 domain 패키지의 데이터 클래스 이름 변경
1. RepositoryEntity -> GithubRepositoryData (data 패키지) 2. GithubRepositoryInfo -> RepositoryEntity (domain 패키지)
Configuration menu - View commit details
-
Copy full SHA for e582fb8 - Browse repository at this point
Copy the full SHA e582fb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ebe4fd - Browse repository at this point
Copy the full SHA 5ebe4fdView commit details -
1. github.component -> gihub.list.component
Configuration menu - View commit details
-
Copy full SHA for ccf05dd - Browse repository at this point
Copy the full SHA ccf05ddView commit details
Commits on Sep 11, 2024
-
1. 사용자 행동 -> 로직의 동작에 초점을 맞춤 2. onClickSnackBar -> onRetry
Configuration menu - View commit details
-
Copy full SHA for 76bc484 - Browse repository at this point
Copy the full SHA 76bc484View commit details -
1. view에서 data로 로직 이동 2. 멤버변수 isHot을 사용하여 노출 여부 판단
Configuration menu - View commit details
-
Copy full SHA for a385f58 - Browse repository at this point
Copy the full SHA a385f58View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7c7023 - Browse repository at this point
Copy the full SHA d7c7023View commit details -
Refactor : GithubRepositoryUiState 변경
1. Loading과 Ready로 구분 2. Ready안에 항목 없음과 에러 여부를 판단하는 boolean값 추가 3. 관련 코드 수정
Configuration menu - View commit details
-
Copy full SHA for 74cf5ad - Browse repository at this point
Copy the full SHA 74cf5adView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.