Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step4 - GitHub(인기 저장소) #32

Open
wants to merge 13 commits into
base: oyj7677
Choose a base branch
from
Open

Commits on Sep 7, 2024

  1. Refactor : MainScreen 컴포넌트 stateful, stateless 오버로딩

    1. MainActivity에 있는 상태값들 stateful한 MainScreen 컴포넌트로 이동.
    oyj7677 committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    c939c8d View commit details
    Browse the repository at this point in the history
  2. Refactor : Github Client 수정

    1. RepositoryEntity, GithubRepositoryInfo에 stars프로퍼티 추가.
    2. 관련 코드 수정
    oyj7677 committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    19178df View commit details
    Browse the repository at this point in the history
  3. Chore : README.md 수정

    1. Step3 완료 체크
    2. Step4 프로그래밍 요구사항 및 기능 요구사항 작성
    oyj7677 committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    c2eb2e0 View commit details
    Browse the repository at this point in the history
  4. Feat : 깃허브 저장소 star 표시 화면 구현

    1. 저장소 칼럼 헤더에 Star 개수 노출
    2.  Star 개수 50개 이상일 시 HOT 문구 노출
    oyj7677 committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    350adaa View commit details
    Browse the repository at this point in the history
  5. Chore : README.md 기능 요구사항 체크

    1. 저장소 Star 개수 노출
    2. 저장소 Star 개수 50개 이상 시 HOT 텍스트 노출
    oyj7677 committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    00f6759 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Refactor : 비즈니스 로직 패키징

    1. domain 패키지 생성
    2. GithubViewModel 파리미터 변경 (저장소 -> 유즈케이스)
    3. GetGithubRepoUseCase 구현
    oyj7677 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d37ccdc View commit details
    Browse the repository at this point in the history
  2. Rename : data 및 domain 패키지의 데이터 클래스 이름 변경

    1. RepositoryEntity -> GithubRepositoryData (data 패키지)
    2. GithubRepositoryInfo -> RepositoryEntity (domain 패키지)
    oyj7677 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e582fb8 View commit details
    Browse the repository at this point in the history
  3. Rename : data 패키지 생성

    1. core 패키지를 data패키지, di패키지로 분리
    oyj7677 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5ebe4fd View commit details
    Browse the repository at this point in the history
  4. Rename : MainTopBar 패키지 이동

    1. github.component -> gihub.list.component
    oyj7677 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ccf05dd View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Refactor : 스낵바 클릭 파라미터 네이밍 변경

    1. 사용자 행동 -> 로직의 동작에 초점을 맞춤
    2. onClickSnackBar -> onRetry
    oyj7677 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    76bc484 View commit details
    Browse the repository at this point in the history
  2. Refactor : HOT 문구 노출 로직 변경

    1. view에서 data로 로직 이동
    2. 멤버변수 isHot을 사용하여 노출 여부 판단
    oyj7677 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a385f58 View commit details
    Browse the repository at this point in the history
  3. Fix : 재시도 요청에 따른 uiState 오류 수정

    1. delay를 추가하여 상태변경을 놓치는 경우를 방지함.
    oyj7677 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d7c7023 View commit details
    Browse the repository at this point in the history
  4. Refactor : GithubRepositoryUiState 변경

    1. Loading과 Ready로 구분
    2. Ready안에 항목 없음과 에러 여부를 판단하는 boolean값 추가
    3. 관련 코드 수정
    oyj7677 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    74cf5ad View commit details
    Browse the repository at this point in the history