[Spring JDBC] 김수민 미션 제출합니다. #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelee2555
reviewed
May 21, 2024
Comment on lines
56
to
63
| /* | ||
| @PostConstruct | ||
| public void init() { | ||
| memberRepository.memberAdd(new MemberDTO("브라운", "2023-01-01", "10:00")); | ||
| memberRepository.memberAdd(new MemberDTO("브라운", "2023-01-02", "11:00")); | ||
| memberRepository.memberAdd(new MemberDTO("브라운", "2023-01-03", "12:00")); | ||
| } | ||
| */ |
jelee2555
reviewed
May 21, 2024
Comment on lines
+21
to
+23
| this.jdbcInsert = new SimpleJdbcInsert(dataSource) | ||
| .withTableName("reservation") | ||
| .usingGeneratedKeyColumns("id"); |
There was a problem hiding this comment.
SimpleJdbcInsert를 이용하여 key holder를 사용하지 않고 primary key 데이터를 받아오셨네요! 참고하겠습니다!!
jelee2555
reviewed
May 21, 2024
Comment on lines
+42
to
+45
| HttpHeaders headers = new HttpHeaders(); | ||
| String uri = "/reservations/" + responseDTO.getId(); | ||
| headers.setLocation(URI.create(uri)); | ||
| ResponseEntity<ReservationDTO> response = new ResponseEntity<>(responseDTO, headers, HttpStatus.CREATED); |
There was a problem hiding this comment.
ResponseEntity.create() 대신 header를 직접 생성해서 ResponseEntity에 넣는 코드를 작성하신 것 같은데 header를 직접 만드는 것이 어떤 장점이 있나요?? 저는 header를 써본 적이 없어서 궁금합니다 :)
There was a problem hiding this comment.
ResponseEntity의 메서드인 created()를 사용해서 만드는 것도 깔끔했을 것 같네요!
저는 장점때문에 직접 헤더를 생성 한 것보다는 HTTP Response를 조작한다는 생각으로 그냥 ResponseEntity를 메서드를 사용하지 않고 직접 구성했습니다
저도 ResponseEntity의 메서드를 활용하는 방식에 익숙해져야겠네요
그리구 혹시 header을 이용하는 방식이 궁금하시다면
https://www.baeldung.com/spring-response-entity
이 링크 참고하셔도 좋을 것 같습니다...!
jelee2555
reviewed
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이번주도 다들 고생많으셨습니당
저는 이전에 DB를 들여오기 전 했던 클래스를 없애기보다는 DB를 들여오면서 새로 만든 클래스로 설정정보만 바꾸고 싶었습니다
그래서 Config 클래스와 인터페이스를 새로 추가했어요
JDBC 미션 범위