[Spring Core] 최규원 미션 제출합니다. #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anhye0n
reviewed
May 28, 2024
Comment on lines
9
to
14
| public record ReservationRequestDto( | ||
| String name, | ||
| @JsonFormat(pattern = "yyyy-MM-dd") LocalDate date, | ||
| @JsonFormat(pattern = "HH:mm") LocalTime time | ||
| Long time | ||
| ) { | ||
| } |
Comment on lines
51
to
54
| var ps = connection.prepareStatement(sql, new String[]{"id"}); | ||
| ps.setString(1, reservation.getName()); | ||
| ps.setDate(2, java.sql.Date.valueOf(reservation.getDate())); | ||
| ps.setTime(3, java.sql.Time.valueOf(reservation.getTime())); | ||
| ps.setLong(3, reservation.getTime().getId()); |
There was a problem hiding this comment.
저번 과제 피드백으로 받았던 NamedParameterJdbcTemplate 혹은 SimpleJdbcInsert을 사용하면 좋을 것 같아요!
SimpleJdbcInsert
NamedParameterJdbcTemplate
Comment on lines
+38
to
+44
| jdbcTemplate.update(connection -> { | ||
| var ps = connection.prepareStatement(sql, new String[]{"id"}); | ||
| ps.setTime(1, java.sql.Time.valueOf(time.getTime())); | ||
| return ps; | ||
| }, keyHolder); | ||
|
|
||
| time.setId(keyHolder.getKey().longValue()); |
There was a problem hiding this comment.
위와 마찬가지로 NamedParameterJdbcTemplate 혹은 SimpleJdbcInsert이 적용되면 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님!
한 주간 미션 수행하시느라 고생 많으셨습니다.
학술제와 예비군이 겹쳐 과제에 많이 신경쓰지 못 한 것 같습니다..
예외 처리들이 조금 미숙한데 미리 양해 부탁드려요ㅠ
계층화가 잘 되어있는지를 신경써서 봐 주시면 감사하겠습니다!
감사합니다!
커밋 범위