Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated email for auth user in github endpoint #11896

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

A91y
Copy link

@A91y A91y commented Sep 23, 2024

https://docs.github.com/en/rest/users/emails?apiVersion=2022-11-28#list-public-email-addresses-for-the-authenticated-user

☕️ Reasoning

Email fetching for github provider updated from https://api.github.com/user/emails to https://api.github.com/user/public_emails according to Github API docs.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes #11895

📌 Resources

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 8:14am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
auth-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 8:14am

Copy link

vercel bot commented Sep 23, 2024

@A91y is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The intention is to grab an email, even if a public one was not found. So it was rather the comment that pointed to the wrong documentation.

packages/next-auth/src/providers/github.ts Outdated Show resolved Hide resolved
packages/next-auth/src/providers/github.ts Outdated Show resolved Hide resolved
@balazsorban44 balazsorban44 merged commit d66ee42 into nextauthjs:v4 Sep 25, 2024
8 of 10 checks passed
@A91y
Copy link
Author

A91y commented Sep 25, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy Refers to `next-auth` v4. Minimal maintenance. providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants