Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apps/dev/solid-start. Not ready for merging due to cookie esm issue; help? #7203

Closed
wants to merge 8 commits into from

Conversation

AlexErrant
Copy link

☕️ Reasoning

Nextjs and Sveltekit each have a dev app. Solid-Start should too!

🧢 Checklist

  • Ready to be merged

❌Not ready for merging

pnpm dev in apps/dev/solid-start with the cookie npm dependency results in the following error message:

An unhandled error occured: ReferenceError: exports is not defined
    at /@fs/home/alex/next-auth/node_modules/.pnpm/[email protected]/node_modules/cookie/index.js:15:1
    at instantiateModule (file:///home/alex/next-auth/node_modules/.pnpm/[email protected]/node_modules/vite/dist/node/chunks/dep-79892de8.js:53996:15)

Hours of googling yielded the following related issues, none of whose solutions worked for me.

vitejs/vite#2579
jshttp/cookie#127
jshttp/cookie#87
sveltejs/kit#1113
vitejs/vite#5668

pnpm dev works if I swap cookie for cookie-esm, but I feel like that PR wouldn't be merged. Seeking help/advice!

@vercel
Copy link

vercel bot commented Apr 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2023 3:14pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Apr 9, 2023 3:14pm

@vercel
Copy link

vercel bot commented Apr 9, 2023

@AlexErrant is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@AlexErrant AlexErrant marked this pull request as draft April 9, 2023 15:12
@github-actions github-actions bot added core Refers to `@auth/core` examples frameworks legacy Refers to `next-auth` v4. Minimal maintenance. solidjs labels Apr 9, 2023
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@auth/[email protected] network, environment +5 balazsorban
[email protected] None +0 mkay581
[email protected] network, filesystem, shell, environment +0 typescript-bot

🚮 Removed packages: @solid-auth/[email protected], [email protected]

@balazsorban44
Copy link
Member

Closing as this has been in draft mode for a very long time, now gathering merge conflicts. Feel free to clean it up and reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` examples frameworks legacy Refers to `next-auth` v4. Minimal maintenance. solidjs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants