Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace babel-eslint with @babel/eslint-parser #80

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Replace babel-eslint with @babel/eslint-parser #80

merged 1 commit into from
Mar 9, 2021

Conversation

st3iny
Copy link
Contributor

@st3iny st3iny commented Mar 9, 2021

The package babel-eslint is deprecated and we should replace it with @babel/eslint-parser.

Can lead to issues like nextcloud/mail#4702 (comment).

@st3iny st3iny added the dependencies Pull requests that update a dependency file label Mar 9, 2021
@st3iny st3iny self-assigned this Mar 9, 2021
ChristophWurst
ChristophWurst approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@ChristophWurst ChristophWurst merged commit 8375780 into master Mar 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/replace-babel-eslint branch March 9, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@st3iny st3iny

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st3iny @ChristophWurst