Add new commands for user management #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
reviewed
Dec 6, 2022
skjnldsv
reviewed
Dec 6, 2022
skjnldsv
reviewed
Dec 6, 2022
skjnldsv
reviewed
Dec 6, 2022
skjnldsv
reviewed
Dec 6, 2022
skjnldsv
reviewed
Dec 6, 2022
susnux
force-pushed
the
feat/user-management
branch
2 times, most recently
from
d59a4ab
to
f54ff6d
Compare
|
On another note, i see some commands clear the session, some don't. Can we make some ground rules?
|
* Added `deleteUser` for deleting existing users on the Nextcloud instance * Added `listUsers` for querying registered user IDs * Added `modifyUser` to change user metadata * Added `userData` to query user metadata (added mainly to test `modifyUser`) Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/user-management
branch
from
f54ff6d
to
e27028c
Compare
|
Fixed the remaining comments, and also
Added such a warning for all methods which reset the cookies
This is already done |
|
@susnux I meant more generally speaking, adding some documentation in the readme maybe when we have time :) But thanks for doing this right now!! You're awesome! Great addition!! 🚀 🪅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleteUserfor deleting existing users on the Nextcloud instancelistUsersfor querying registered user IDsmodifyUserto change user metadatauserDatato query user metadata (added mainly to testmodifyUser)This commands are currently used at least by the text app, but they are commonly useful also for other apps.
So I guess it would be best to integrate them into this library as a part of nextcloud/text#2201 .