Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not try to slice in chunk larger than the File itself #1057

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jan 23, 2024

Context

If you try to upload a large file (like 2GB) with chunk upload disabled, the browser will misbehave

Resolution

We stop slicing the entire file and we just return its blob directly

Fix nextcloud/server#42704

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews labels Jan 23, 2024
@skjnldsv skjnldsv requested a review from susnux January 23, 2024 17:15
@skjnldsv skjnldsv self-assigned this Jan 23, 2024
@skjnldsv skjnldsv requested a review from ShGKme January 23, 2024 17:27
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d31c8b) 91.25% compared to head (3e40a97) 16.85%.
Report is 3 commits behind head on master.

❗ Current head 3e40a97 differs from pull request most recent head 5f3b0d4. Consider uploading reports for the commit 5f3b0d4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1057       +/-   ##
===========================================
- Coverage   91.25%   16.85%   -74.40%     
===========================================
  Files           3        9        +6     
  Lines          80      445      +365     
  Branches       16       77       +61     
===========================================
+ Hits           73       75        +2     
- Misses          4      367      +363     
  Partials        3        3               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skjnldsv skjnldsv force-pushed the fix/chunk-large-whole branch 2 times, most recently from 3e40a97 to 109a77a Compare January 24, 2024 07:21
@skjnldsv skjnldsv merged commit a54d112 into master Jan 24, 2024
15 checks passed
@skjnldsv skjnldsv deleted the fix/chunk-large-whole branch January 24, 2024 07:26
@susnux susnux mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NC 28 Cannot upload file larger than 2GB (javascript error)
2 participants