Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refactor logger and fix badges in README #1173

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix: Refactor logger and fix badges in README #1173

merged 2 commits into from
Apr 26, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 26, 2024 •
edited
Loading

  • Refactor the logger code - we no longer need to inject the user manually but can use the detectUser function
  • Add a tiny test for the logger to ensure it works and sets the correct context
  • Remove utils/l10n.ts from the code coverage - it makes no sense to test this
  • Fixed links in README and badges

@susnux
fix: Refactor logger code and add l10n as ignored for code coverage
0a0c7c6 
It makes no sense to test the l10n part...

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix(doc): Adjust links and badges in README
3b6ae2c 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Apr 26, 2024
@susnux susnux requested review from artonge and Pytal April 26, 2024 14:47
@susnux susnux merged commit 145f9aa into main Apr 26, 2024
16 checks passed
@susnux susnux deleted the fix/refactor-code-coverafe branch April 26, 2024 16:50
@susnux susnux mentioned this pull request May 23, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Jul 2, 2024
Merged
@JhayceFrancis JhayceFrancis mentioned this pull request Aug 5, 2024
Open
@JhayceFrancis JhayceFrancis mentioned this pull request Sep 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @Pytal