Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cypress selectors for new menu entries #1289

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

skjnldsv
Copy link
Contributor

It was missing before:
image

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Jul 19, 2024
@skjnldsv skjnldsv requested a review from susnux July 19, 2024 05:54
@skjnldsv skjnldsv self-assigned this Jul 19, 2024
@skjnldsv skjnldsv force-pushed the feat/data-cy-attrs branch 2 times, most recently from 59ff834 to 8c0c72f Compare July 19, 2024 06:37
@skjnldsv skjnldsv requested a review from ShGKme July 25, 2024 09:19
Copy link

codecov bot commented Jul 25, 2024

Bundle Report

Changes will increase total bundle size by 586 bytes ⬆️

Bundle name Size Change
@nextcloud/upload-esm 323.08kB 293 bytes ⬆️
@nextcloud/upload-esm-cjs 325.87kB 293 bytes ⬆️

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better than class names ✅

@skjnldsv skjnldsv merged commit 75e423f into main Jul 25, 2024
17 checks passed
@skjnldsv skjnldsv deleted the feat/data-cy-attrs branch July 25, 2024 10:47
@skjnldsv skjnldsv mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants