fix: Always request current content when triggering a menu entry #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 8.32kB ⬆️
|
|
Fixed version on server looks like this then: Bildschirmaufnahme_20240801_211128.webm |
4 tasks
skjnldsv
approved these changes
Aug 1, 2024
We need to make sure we work with an up-to-date version of the current content, e.g. if a file was removed or added, so reload the current content on click. The using app (esp. files) should have cached version so no requests are needed. (for files this is already the case). Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/new-menu-current-content
branch
from
4d7f9cb
to
9768088
Compare
This was referenced Aug 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure we work with an up-to-date version of the current content, e.g. if a file was removed or added, so reload the current content on click.
The using app (esp. files) should have cached version so no requests are needed. (for files this is already the case).
When releasing this update and merging in server I will provide a cached "getContent" function (load from store if already known) to mitigate performance issues.
edit here it is: nextcloud/server#46966