Don't rely on Vue.prototype.t and properly extract all strings #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/586/translate
branch
from
363b31c
to
9024527
Compare
raimund-schluessler
requested review from
ChristophWurst,
skjnldsv,
juliushaertl and
szaimen
raimund-schluessler
added
3. to review
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
changed the title
ChristophWurst
approved these changes
Sep 13, 2021
|
/backport to stable4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the necessity to bind
window.ttoVue.prototype.t. This makes using the components a bit less error prone on first usage and cleans up the Vue instance. The Netlify build still looks fine and e.g. the Calendar app works well.We should furthermore not use
this.t(...)(i.e. thel10nmixin) as it breaks the l10n extraction. The mixin is fine if we needtfor the template though.Closes #586.