📰 Update AppNavigationItem design #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
requested review from
nickvergessen,
jancborchardt,
juliushaertl,
CarlSchwan and
nimishavijay
|
CarlSchwan
approved these changes
Aug 17, 2022
AndyScherzinger
changed the title
jancborchardt
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Looks great, but agree with @nickvergessen’s remark regarding animation speed variable use. :)
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
marcoambrosini
force-pushed
the
feature/update-appnavigationitem-design
branch
from
7c9bdb1
to
ef3b1ab
Compare
Signed-off-by: Marco Ambrosini <[email protected]>
Merged
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3049
Signed-off-by: Marco Ambrosini [email protected]