-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show actions on hover/focus/active #3061
Show actions on hover/focus/active #3061
Conversation
3fc9a12
to
f39931b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c37e61a
to
ef1d162
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
4b20621
to
783243d
Compare
theres still something wrong with the hover, on mail, when i hover over the number of unread messages the action menu is not shown. Maybe this could be fixed on apps separately? Kazam_screencast_00034.mp4 |
or this other problem with showing the action menu on account settings: Kazam_screencast_00035.mp4 |
Are you sure you pulled @GretaD? |
yes, but i think the linking failed me, im working on another ticket and the linking is not working properly, will try again in a minute |
783243d
to
16cb199
Compare
Have you tried again @GretaD ? |
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
16cb199
to
951911c
Compare
The same happens for Tasks. The counter disappears on hover, but the actions don't appear. They are only visible when the entry is selected and hovered. Do we need to adjust something in the apps? @marcoambrosini |
I can't reproduce this in mail, it seems to be working just fine there. Are you using some custom css? Screen.Recording.2022-08-24.at.08.36.52.mov |
after the update i cannot reproduce it either, the hover looks fine |
fix #3048
Signed-off-by: Marco Ambrosini [email protected]