Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show actions on hover/focus/active #3061

Merged

Conversation

marcoambrosini
Copy link
Contributor

@marcoambrosini marcoambrosini commented Aug 18, 2022

fix #3048

Signed-off-by: Marco Ambrosini [email protected]

@marcoambrosini marcoambrosini force-pushed the feature/3048/fix-actions-display-on-appnavigationitem branch from 3fc9a12 to f39931b Compare August 18, 2022 10:45
@marcoambrosini marcoambrosini changed the title Show actions on hover and focus Show actions on hover/focus/active Aug 18, 2022
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews enhancement New feature or request labels Aug 18, 2022
@GretaD

This comment was marked as outdated.

@marcoambrosini marcoambrosini added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 18, 2022
@marcoambrosini

This comment was marked as outdated.

@marcoambrosini marcoambrosini force-pushed the feature/3048/fix-actions-display-on-appnavigationitem branch 2 times, most recently from c37e61a to ef1d162 Compare August 19, 2022 14:43
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@marcoambrosini marcoambrosini self-assigned this Aug 19, 2022
@marcoambrosini marcoambrosini added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 19, 2022
@marcoambrosini marcoambrosini force-pushed the feature/3048/fix-actions-display-on-appnavigationitem branch from 4b20621 to 783243d Compare August 19, 2022 15:18
@GretaD
Copy link
Contributor

GretaD commented Aug 22, 2022

theres still something wrong with the hover, on mail, when i hover over the number of unread messages the action menu is not shown. Maybe this could be fixed on apps separately?

Kazam_screencast_00034.mp4

@GretaD
Copy link
Contributor

GretaD commented Aug 22, 2022

or this other problem with showing the action menu on account settings:

Kazam_screencast_00035.mp4

@marcoambrosini
Copy link
Contributor Author

Are you sure you pulled @GretaD?

@GretaD
Copy link
Contributor

GretaD commented Aug 22, 2022

Are you sure you pulled @GretaD?

yes, but i think the linking failed me, im working on another ticket and the linking is not working properly, will try again in a minute

@marcoambrosini marcoambrosini force-pushed the feature/3048/fix-actions-display-on-appnavigationitem branch from 783243d to 16cb199 Compare August 23, 2022 14:15
@skjnldsv
Copy link
Contributor

yes, but i think the linking failed me, im working on another ticket and the linking is not working properly, will try again in a minute

Have you tried again @GretaD ?

@marcoambrosini marcoambrosini force-pushed the feature/3048/fix-actions-display-on-appnavigationitem branch from 16cb199 to 951911c Compare August 23, 2022 14:19
@skjnldsv skjnldsv merged commit 5168c73 into master Aug 23, 2022
@skjnldsv skjnldsv deleted the feature/3048/fix-actions-display-on-appnavigationitem branch August 23, 2022 14:59
@raimund-schluessler
Copy link
Contributor

theres still something wrong with the hover, on mail, when i hover over the number of unread messages the action menu is not shown. Maybe this could be fixed on apps separately?

The same happens for Tasks. The counter disappears on hover, but the actions don't appear. They are only visible when the entry is selected and hovered. Do we need to adjust something in the apps? @marcoambrosini

@marcoambrosini
Copy link
Contributor Author

I can't reproduce this in mail, it seems to be working just fine there. Are you using some custom css?

Screen.Recording.2022-08-24.at.08.36.52.mov

@GretaD
Copy link
Contributor

GretaD commented Aug 24, 2022

I can't reproduce this in mail, it seems to be working just fine there. Are you using some custom css?

after the update i cannot reproduce it either, the hover looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

☝️ Show app navigation actions menu only for active/hover/focus
5 participants