Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcRichText): crash on router links rendering #5672

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 5, 2024

☑️ Resolves

  • Talk is broken when there is a link to another chat in the chat
  • Fix warnings and errors

To test:

  1. Checkout https://github.com/nextcloud/spreed/tree/vue3
  2. Before linking nextcloud-vue - remove rm -rf node_modules/vue-router from nextcloud-vue repo (or use npm pack instead of npm link)
  3. Send a link to another chat in a chat

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • move vue-router from devDeps to deps to externalize it. Otherwise it is built in and we have 2 routers. We should take router from package users, not during the build.
    Fixes:
    image
  • move vue from peer to deps (no changes, just make it correct)
  • use function slot in render
    Fixes:
    image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Jun 5, 2024
@ShGKme ShGKme added this to the 9.0.0-alpha.4 milestone Jun 5, 2024
@ShGKme ShGKme self-assigned this Jun 5, 2024
@ShGKme ShGKme changed the title fix(NcRichText): crash on router links rendering [next] fix(NcRichText): crash on router links rendering Jun 5, 2024
@ShGKme

This comment was marked as outdated.

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@juliushaertl juliushaertl merged commit 87fca26 into next Jun 6, 2024
17 checks passed
@juliushaertl juliushaertl deleted the fix/NcRichText-inject-router branch June 6, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: richtext Related to the richtext component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants