NcAppSettingsSection: make titles normal h3 size #5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
reviewed
Jul 17, 2024
|
@GVodyanov see nextcloud/server#43393. Until recently, headings in Nextcloud were a bit random |
So is this PR still relevant or should we wait for someone to come along and standardize this everywhere? @ChristophWurst |
|
I'd say it is still relevant. The tricky part is to find a solution that works with 28/29 and 30. This lib is compatible with both. |
susnux
reviewed
Jul 18, 2024
susnux
approved these changes
Jul 18, 2024
|
/backport to next |
Signed-off-by: Grigory V <[email protected]>
GVodyanov
force-pushed
the
style/make-settings-titles-larger
branch
from
98f16ac
to
7fd2ed5
Compare
ChristophWurst
approved these changes
Jul 19, 2024
This was referenced Aug 14, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
Not sure why their size was limited in the first place