Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor NcButton #6033

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

feat: Refactor NcButton #6033

wants to merge 1 commit into from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 30, 2024

☑️ Resolves

  1. Make it a template component instead of a render function
  2. Add a text prop to allow passing text content as prop
  3. Add noIconAriaHidden to allow making the icon appear on the accessible tree

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

1. Make it a template component instead of a render function
2. Add a `text` prop to allow passing text content as prop
3. Add `noIconAriaHidden` to allow making the icon appear on the accessible tree

Signed-off-by: Ferdinand Thiessen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant