Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcCheckboxRadioSwitch): switch may always have checked-like background #6055

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(NcCheckboxRadioSwitch): switch may always have checked-like background #6055

merged 1 commit into from
Sep 5, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 5, 2024 •
edited
Loading

☑️ Resolves

  • Fix issues caused by wrong stylesheet import order for NcCheckboxRadioSwitch

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade
    Signed-off-by: Antreesy [email protected]

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: checkbox-radio-switch Related to the checkbox-radio-switch component labels Sep 5, 2024
@Antreesy Antreesy added this to the 8.18.0 milestone Sep 5, 2024
@Antreesy Antreesy self-assigned this Sep 5, 2024
@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 5, 2024

During the push understood, that second solution might be better 🦭
Please check both first and second commits

susnux
susnux approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer the second one

ShGKme
ShGKme approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second one 👀

@ShGKme ShGKme changed the title fix: increase (or decrease) selectors specificity fix(NcCheckboxRadioSwitch): switch may always have checked-like background Sep 5, 2024
@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 5, 2024

/backport to next

@Antreesy Antreesy merged commit f0160e6 into master Sep 5, 2024
19 checks passed
@Antreesy Antreesy deleted the fix/noid/deep-styles branch September 5, 2024 19:30
@backportbot backportbot bot mentioned this pull request Sep 5, 2024
Merged
This was referenced Sep 12, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Projects
None yet
Milestone
8.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @susnux @ShGKme