Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcRichText): show links title for desktop client #6127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(NcRichText): show links title for desktop client #6127

wants to merge 1 commit into from

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Oct 2, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@DorraJaouad DorraJaouad added 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Oct 2, 2024
@DorraJaouad DorraJaouad added this to the 8.19.1 milestone Oct 2, 2024
@DorraJaouad DorraJaouad self-assigned this Oct 2, 2024
@DorraJaouad DorraJaouad marked this pull request as ready for review October 2, 2024 07:09
@Antreesy
Copy link
Contributor

Antreesy commented Oct 2, 2024

Should we do it all the time (without props)? Or if href doesn't match content?

@ShGKme
Copy link
Contributor

ShGKme commented Oct 3, 2024

Should we do it all the time (without props)? Or if href doesn't match content?

Then it duplicates already existing web-browser feature

@ShGKme ShGKme added the enhancement New feature or request label Oct 3, 2024
@ShGKme ShGKme modified the milestones: 8.19.1, 8.20.0 Oct 3, 2024
@DorraJaouad
Copy link
Contributor Author

Or if href doesn't match content?

I say we keep the same for all links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme Awaiting requested review from ShGKme

@Antreesy Antreesy Awaiting requested review from Antreesy

At least 2 approving reviews are required to merge this pull request.

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review Waiting for reviews enhancement New feature or request feature: richtext Related to the richtext component
Projects
None yet
Milestone
8.20.0
Development

Successfully merging this pull request may close these issues.

Hovering a markdown link with the mouse should give an indication which page will be opened
3 participants
@DorraJaouad @Antreesy @ShGKme