Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gettext-based translations #854

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Add gettext-based translations #854

merged 1 commit into from
Feb 24, 2020

Conversation

ChristophWurst
Copy link
Contributor

@ChristophWurst ChristophWurst commented Feb 13, 2020

Fixes #97

Todo

@ChristophWurst
Copy link
Contributor Author

Test placeholder replacement (not sure if %s or {placeholder} should be used

We'll eventually need this for every package that is translated, so I added this functionality to the l10n package: nextcloud-libraries/nextcloud-l10n#88

@nickvergessen
Copy link
Contributor

Test placeholder replacement (not sure if %s or {placeholder} should be used

JS uses {} + %n
PHP uses %s, %1$s + %n

Ref nextcloud/documentation#1827

@ChristophWurst
Copy link
Contributor Author

JS uses {} + %n

Done via nextcloud-libraries/nextcloud-l10n#88. Please have a look :)

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst marked this pull request as ready for review February 21, 2020 10:22
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 21, 2020
Copy link
Contributor

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this so we can setup transifex push/pull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add translation plugin
3 participants