fix access array offset which doesn't exist

Successor hook fileMovePost is only processed if no error occured in fileMove hook Signed-off-by: Jan Messer <[email protected]>
nextcloud · Jul 23, 2024 · f371e65 · f371e65
1 parent 327dcd0
commit f371e65
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/FilesHooks.php b/lib/FilesHooks.php
@@ -234,6 +234,7 @@ public function fileMove($oldPath, $newPath) {
 			return;
 		}
 
+		$moveCase = $this->moveCase;
 		if (strpos($oldDir, $newDir) === 0) {
 			/**
 			 * a/b/c moved to a/c
@@ -243,7 +244,7 @@ public function fileMove($oldPath, $newPath) {
 			 * - a/b/ shared: delete
 			 * - a/ shared: move/rename
 			 */
-			$this->moveCase = 'moveUp';
+			$moveCase = 'moveUp';
 		} elseif (strpos($newDir, $oldDir) === 0) {
 			/**
 			 * a/b moved to a/c/b
@@ -253,7 +254,7 @@ public function fileMove($oldPath, $newPath) {
 			 * - a/c/ shared: add
 			 * - a/ shared: move/rename
 			 */
-			$this->moveCase = 'moveDown';
+			$moveCase = 'moveDown';
 		} else {
 			/**
 			 * a/b/c moved to a/d/c
@@ -264,7 +265,7 @@ public function fileMove($oldPath, $newPath) {
 			 * - a/d/ shared: add
 			 * - a/ shared: move/rename
 			 */
-			$this->moveCase = 'moveCross';
+			$moveCase = 'moveCross';
 		}
 
 		[$this->oldParentPath, $this->oldParentOwner, $this->oldParentId] = $this->getSourcePathAndOwner($oldDir);
@@ -282,6 +283,7 @@ public function fileMove($oldPath, $newPath) {
 			$oldAccessList['users'] = array_merge($oldAccessList['users'], $this->getAffectedUsersFromCachedMounts($oldFileId));
 		}
 
+		$this->moveCase = $moveCase;
 		$this->oldAccessList = $oldAccessList;
 	}