Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if users is set #1281

Closed
wants to merge 1 commit into from
Closed

Check if users is set #1281

wants to merge 1 commit into from

Conversation

solracsf
Copy link
Member

Error: Undefined array key "users"
Exception: array_keys(): Argument #1 ($array) must be of type array, null given

@artonge
Copy link
Collaborator

artonge commented Aug 18, 2023

In which case can it be empty? Do you have reproduction steps?

@solracsf
Copy link
Member Author

No sorry, just some errors like these in the logs...

@artonge
Copy link
Collaborator

artonge commented Aug 18, 2023

I am wondering if this won't juste hide another issue. Can you investigate ?

@github-actions

This comment was marked as off-topic.

@artonge

This comment was marked as outdated.

@solracsf

This comment was marked as resolved.

@artonge
Copy link
Collaborator

artonge commented Oct 11, 2023

Maybe. Do you still have the log?

@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
lib/FilesHooks.php Outdated Show resolved Hide resolved
@solracsf
Copy link
Member Author

This will also fix:

array_keys(): Argument #1 ($array) must be of type array, null given in file '/var/www/nextcloud/apps/activity/lib/FilesHooks.php' line 243"

Can we go ahead and merge + backport it?

@solracsf solracsf requested a review from susnux January 22, 2024 15:40
@susnux
Copy link
Contributor

susnux commented Jan 22, 2024

I think this should be fixed in getUserPathsFromPath because there are other places where it is used

Signed-off-by: Git'Fellow <[email protected]>

Fix psalm

Signed-off-by: Git'Fellow <[email protected]>

Use empty array if array is unset

Signed-off-by: Git'Fellow <[email protected]>
Copy link

cypress bot commented May 7, 2024

2 flaky tests on run #1518 ↗︎

0 10 0 0 Flakiness 2

Details:

Check if users is set
Project: Activity Commit: 8304752230
Status: Passed Duration: 03:16 💡
Started: May 7, 2024 6:35 PM Ended: May 7, 2024 6:39 PM
Flakiness  cypress/e2e/sidebar.cy.ts • 2 flaky tests • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has favorite activity Test Replay Screenshots
Check activity listing in the sidebar > Has share activity Test Replay Screenshots

Review all test suite changes for PR #1281 ↗︎

@susnux
Copy link
Contributor

susnux commented May 7, 2024

I think this should be fixed in getUserPathsFromPath because there are other places where it is used

I think this is still valid to not just hide issues

@Messj1
Copy link
Contributor

Messj1 commented Jul 18, 2024

@ solracsf Is this problem is related to #1056 ? Can you Check if following commit helps: 8facb65

@solracsf
Copy link
Member Author

Maybe, but as long as I don't see this in logs a long time ago, and this PR is not the good approach anyway, closing here 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants