Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add sharing activity for teams #1754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 24, 2024

This adds support for Teams (previously "Circles"), the user notification already work, but the notification for the owner and sharer need support in the files_sharing app.

So if this is merged we can add the required providers in files_sharing.

But one thing to mention: For groups we paginate the members, I did not find a nice way to do this with teams.
So maybe @ArtificialOwl can have a look at the member query if there is something to improve performance wise (e.g. pagination?).

Copy link

cypress bot commented Aug 24, 2024

Activity    Run #1903

Run Properties:  status check passed Passed #1903  •  git commit fbe60ba063: feat: Add sharing activity for teams
Project Activity
Branch Review feat/activity-for-team-share
Run status status check passed Passed #1903
Run duration 02m 57s
Commit git commit fbe60ba063: feat: Add sharing activity for teams
Committer Ferdinand Thiessen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10
View all changes introduced in this branch ↗︎

Copy link
Collaborator

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susnux susnux force-pushed the feat/activity-for-team-share branch 3 times, most recently from 77c13d1 to b69f982 Compare August 31, 2024 12:32
This adds support for Teams (previously "Circles"),
the user notification already work, but the notification for the owner
and sharer need support in the `files_sharing` app.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the feat/activity-for-team-share branch from b69f982 to 2295c86 Compare August 31, 2024 12:32
@susnux
Copy link
Contributor Author

susnux commented Aug 31, 2024

TIL: protected (Foo&Bar)|Baz $variable does not work with PHP 8.1 but only 8.2 😅
(was in the test like: protected (Class&MockObject)|null $variable )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants