Rewrite the settings in vue #589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
feature/vue_rewrite
branch
2 times, most recently
from
a11016d
to
5247f56
Compare
artonge
force-pushed
the
feature/vue_rewrite
branch
3 times, most recently
from
b3eaa8d
to
848875e
Compare
artonge
commented
Jul 1, 2021
| @@ -8,5 +8,6 @@ module.exports = { | |||
| 'node/no-unpublished-import': ['error', { | |||
| allowModules: ['@vue/test-utils', '@testing-library/vue'], | |||
| }], | |||
| 'valid-jsdoc': 'off', | |||
There was a problem hiding this comment.
Needed until a new version of nextcloud/eslint-config is released
artonge
commented
Jul 1, 2021
|
|
||
| <template> | ||
| <div> | ||
| <!-- TODO: should I use the global grid class ? --> |
There was a problem hiding this comment.
@skjnldsv ? An opinion ?
artonge
commented
Jul 1, 2021
| /** | ||
| * Toggle the availability of mail notifications | ||
| * | ||
| * @param {import('vuex').ActionContext<SettingsState, SettingsState>} store - |
There was a problem hiding this comment.
Ugly way to add typing from a node_module
artonge
requested review from
nickvergessen,
skjnldsv and
icewind1991
and removed request for
nickvergessen
|
@skjnldsv the background around an hovered checkbox is not round, is it on purpose ?
|
artonge
force-pushed
the
feature/vue_rewrite
branch
from
2587918
to
6ddf1de
Compare
artonge
force-pushed
the
feature/vue_rewrite
branch
2 times, most recently
from
e6465b0
to
d75bc18
Compare
artonge
force-pushed
the
feature/vue_rewrite
branch
2 times, most recently
from
fa62f01
to
8cbc10a
Compare
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
feature/vue_rewrite
branch
from
8cbc10a
to
400a8c1
Compare
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 25, 2021
This was referenced Apr 7, 2022
This was referenced Aug 12, 2022
|
This was integrated in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the settings in Vue.js
User settings
Admin settings