Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle submit button based on unsaved changes #5576

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

ernolf
Copy link
Collaborator

@ernolf ernolf commented Nov 11, 2024

  • refactor: extract 'optional containers' to separate twig include
  • refactor: apply DRY principles to optional-containers code
  • feat: toggle submit button based on unsaved changes

@ernolf ernolf requested a review from szaimen November 11, 2024 21:38
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Nov 11, 2024
@szaimen szaimen added this to the next milestone Nov 11, 2024
Signed-off-by: Simon L. <[email protected]>
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot! 😊

@szaimen szaimen merged commit c9c55be into main Nov 12, 2024
7 checks passed
@szaimen szaimen deleted the ernolf/submit-button-fix branch November 12, 2024 14:14
@szaimen
Copy link
Collaborator

szaimen commented Nov 12, 2024

This is now released with v10.0.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants