Skip to content

Commit

Permalink
Fix upload list touch target by removing frame layout.
Browse files Browse the repository at this point in the history
  • Loading branch information
surinder-tsys authored and pull[bot] committed Jan 22, 2024
1 parent 09afe18 commit 15c72a1
Showing 1 changed file with 11 additions and 15 deletions.
26 changes: 11 additions & 15 deletions app/src/main/res/layout/upload_list_item.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

<!--
Nextcloud Android client application
@author TSI-mc
Copyright (C) 2018 Tobias Kaminsky
Copyright (C) 2018 Nextcloud
Copyright (C) 2023 TSI-mc
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
Expand All @@ -21,6 +23,7 @@
-->

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/upload_list_item_layout"
android:layout_width="match_parent"
android:layout_height="wrap_content"
Expand Down Expand Up @@ -127,22 +130,15 @@

</LinearLayout>

<FrameLayout
<ImageButton
android:id="@+id/upload_right_button"
tools:src="@drawable/ic_action_cancel_grey"
android:layout_width="@dimen/min_list_item_size"
android:layout_height="@dimen/standard_list_item_size"
android:layout_gravity="center_vertical"
android:focusable="false"
android:focusableInTouchMode="false"
android:paddingEnd="@dimen/zero"
android:paddingStart="@dimen/standard_half_padding">

<ImageButton
android:id="@+id/upload_right_button"
android:layout_width="@dimen/upload_list_item_image_size"
android:layout_height="@dimen/upload_list_item_image_size"
android:layout_gravity="center|end"
android:background="@android:color/transparent"
android:contentDescription="@string/upload_item_action_button" />
</FrameLayout>
android:layout_gravity="center|end"
android:background="@android:color/transparent"
android:contentDescription="@string/upload_item_action_button"
android:paddingStart="@dimen/standard_double_padding"
android:paddingEnd="@dimen/zero" />

</LinearLayout>

0 comments on commit 15c72a1

Please sign in to comment.