Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.30] File Name Validator Improvements #13604

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 23, 2024

Backport of PR #13577

Signed-off-by: Andy Scherzinger <[email protected]>
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13604.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger
Copy link
Member

@tobiasKaminsky to the rescue? 🙏

@tobiasKaminsky
Copy link
Member

The very first CI after a branch off never works.
We could either c&p from master, or simply merge and then this is taken as new baseline.

Copy link

Lint

Typestable-3.30PR
Warnings6060
Errors33

SpotBugs

CategoryBaseNew
Bad practice6463
Correctness6364
Dodgy code297300
Experimental11
Internationalization77
Malicious code vulnerability10
Multithreaded correctness66
Performance5353
Security1818
Total510512

SpotBugs increased!

@nextcloud nextcloud deleted a comment from github-actions bot Sep 24, 2024
@tobiasKaminsky
Copy link
Member

C&P it now and restarted analysis.

@tobiasKaminsky
Copy link
Member

@alperozturk96 now it worked

@alperozturk96
Copy link
Collaborator

@tobiasKaminsky Analysis / analysis (pull_request) fails due to increased spot bugs. Shall we just merge it?

@tobiasKaminsky tobiasKaminsky merged commit c284d5f into stable-3.30 Sep 30, 2024
17 of 19 checks passed
@tobiasKaminsky tobiasKaminsky deleted the backport/13577/stable-3.30 branch September 30, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants