Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify FileNameValidator Check #13613

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Simplify FileNameValidator Check #13613

merged 1 commit into from
Sep 30, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Sep 24, 2024 •
edited
Loading

  • Tests written, or not not needed

Changes

  • Use find instead of a for loop with an if check.
  • Show an error message if a space character exists at the beginning of the filename.

@alperozturk96
Use find instead for loop
4687f7c 
Signed-off-by: alperozturk <[email protected]>
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13613.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code297297
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total510510

@tobiasKaminsky tobiasKaminsky merged commit ae1be9b into master Sep 30, 2024
22 checks passed
@tobiasKaminsky tobiasKaminsky deleted the simplify-file-name-validator-check branch September 30, 2024 06:36
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.30

@backportbot backportbot bot mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @tobiasKaminsky