Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Throw An Exception in SyncOperation #13680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 2, 2024

  • Tests written, or not not needed

I returned an ACCOUNT_EXCEPTION for testing purposes, and as can be seen in the video, only the capabilities cannot be updated.

cap.mp4

Copy link

github-actions bot commented Oct 2, 2024

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code296296
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total509509

@tobiasKaminsky
Copy link
Member

Accordin to exception message this is to prevent running a sync operation with a file data storage manager on a wrong/null account.
Have you tested such an operation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants