TimSort, first fix values, then sort

[tobiasKaminsky]

TimSort is crashing because values (e.g. upload status) is changing while sorting.
Therefore the idea is to "fix" these values for sorting.
Drawback is that it can happen that sorting is already outdated, once sorting is done.
But we refresh after each upload and also a manual refresh can be triggered.

This is currently #1 bug on google play console.

For developing, I set each value of OCUpload to random and had a crash on nearly every sorting/refresh.
With this enhancement, I had no crash at all, although every value changed at any time.

We are using these fixedValues only for sorting and read-only.
So a changing status, e.g. because upload failed, will still be reflected on next sort.

Signed-off-by: tobiasKaminsky [email protected]

[codecov]

Codecov Report

Merging #2781 into master will increase coverage by 0.02%.
The diff coverage is 31.85%.

@@            Coverage Diff            @@
##           master   #2781      +/-   ##
=========================================
+ Coverage    6.39%   6.42%   +0.02%     
=========================================
  Files         294     297       +3     
  Lines       29443   29721     +278     
  Branches     4252    4286      +34     
=========================================
+ Hits         1884    1909      +25     
- Misses      27272   27528     +256     
+ Partials      287     284       -3

Impacted Files	Coverage Δ
...owncloud/android/ui/adapter/UploadListAdapter.java	0% <0%> (ø)	⬆️
.../owncloud/android/files/services/FileUploader.java	0.2% <0%> (ø)	⬆️
...cloud/android/datamodel/UploadsStorageManager.java	20.16% <100%> (ø)	⬆️
...ncloud/android/operations/UploadFileOperation.java	25.54% <100%> (ø)	⬆️
...rc/main/java/com/owncloud/android/db/OCUpload.java	29.62% <38.63%> (-2.12%)	⬇️
...ncloud/android/datamodel/SyncedFolderProvider.java	8.8% <0%> (-1.3%)	⬇️
...loud/android/datamodel/FileDataStorageManager.java	10.52% <0%> (-0.06%)	⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java	0% <0%> (ø)	⬆️
.../java/com/owncloud/android/utils/DisplayUtils.java	5.72% <0%> (ø)	⬆️
...oud/android/ui/activity/NotificationsActivity.java	0% <0%> (ø)	⬆️
... and 33 more

[AndyScherzinger]

👍 code changes look good to me, m-prefixing is fine to have the file consistent b/c a removal within the whole file would lead to a large amount of changes throughout the app which would pollute this PR review wise, but we might tackle this in a separate PR :)

[mario]

👍

[nextcloud-android-bot]

Lint

This	93 warnings
Master	93 warnings

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	165
Experimental Warnings	4
Internationalization Warnings	12
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	159
Security Warnings	163
Dodgy code Warnings	207
Total	763

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	166
Experimental Warnings	4
Internationalization Warnings	12
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	158
Security Warnings	163
Dodgy code Warnings	207
Total	763