use default open chooser with "just once", "always" #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tobiasKaminsky <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11450.apk |
Codacy299Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #4746 +/- ##
============================================
- Coverage 17.43% 17.41% -0.02%
Complexity 3 3
============================================
Files 376 376
Lines 32309 32307 -2
Branches 4560 4560
============================================
- Hits 5633 5627 -6
- Misses 25769 25770 +1
- Partials 907 910 +3
|
|
@AndyScherzinger or do you recall a reason why we should not do this? |
|
@tobiasKaminsky you just resolved #4061 ❤️ |
tobiasKaminsky
added a commit
that referenced
this pull request
Oct 30, 2019
2a43da6 Merge pull request #4746 from nextcloud/createChooser f8d7ddd Merge pull request #4758 from nextcloud/fixDarkTheme bee8770 - fix typo in styles - fix sign up with provider in dark primary color cc710b0 Merge pull request #3459 from nextcloud/dark_theme c1aa005 changes due to code review c801a2c Merge pull request #4744 from nextcloud/v3100_Alpha1 12fe91a use default open chooser with "just once", "always" 8b4481f [tx-robot] updated from transifex 2ea1f4e daily dev 20191029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4061
Resolves #4857
Before / new
Test on
Signed-off-by: tobiasKaminsky [email protected]